Addressing a few vulnerability issues #1897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Nov 7, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/minio/minio-go/v7 | |||
|
|
|||
| go 1.17 | |||
| go 1.21.3 | |||
There was a problem hiding this comment.
Suggested change
| go 1.21.3 | |
| go 1.19 |
There was a problem hiding this comment.
1.19 suffers from the same vulnerabilities unfortunately. I saw that you had some CICD to be backward compatible with 1.19 which might be a bigger change. I'm happy to accept the changes but they won't solve the issue.
There was a problem hiding this comment.
The security vulnerabilities test fails on 1.21 as well, that's why I explicitly pinned to 1.21.3
|
I don't think this PR doing anything, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the following current issue related to golang version.
govulncheck ./...
Scanning your code and 163 packages across 14 dependent modules for known vulnerabilities...
=== Informational ===
Found 3 vulnerabilities in packages that you import, but there are no call
stacks leading to the use of these vulnerabilities. You may not need to
take any action. See https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck
for details.
Vulnerability #1: GO-2023-2102
HTTP/2 rapid reset can cause excessive work in net/http
More info: https://pkg.go.dev/vuln/GO-2023-2102
Standard library
Found in: net/[email protected]
Fixed in: net/[email protected]
Vulnerability #2: GO-2023-2045
Memory exhaustion in QUIC connection handling in crypto/tls
More info: https://pkg.go.dev/vuln/GO-2023-2045
Standard library
Found in: crypto/[email protected]
Fixed in: crypto/[email protected]
Vulnerability #3: GO-2023-2044
Panic when processing post-handshake message on QUIC connections in
crypto/tls
More info: https://pkg.go.dev/vuln/GO-2023-2044
Standard library
Found in: crypto/[email protected]
Fixed in: crypto/[email protected]
No vulnerabilities found.
Share feedback at https://go.dev/s/govulncheck-feedback.